hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alejandro Abdelnur (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7560) Make hadoop-common a POM module with sub-modules (common & alfredo)
Date Wed, 24 Aug 2011 19:38:31 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13090432#comment-13090432

Alejandro Abdelnur commented on HADOOP-7560:

from IRC

[12:12pm] tucu: mmmhh, thought the other why around as my arguments in the JIRA to go flat
were not disputed.
[12:14pm] acmurthy: sorry
[12:14pm] acmurthy: but having hadoop-yarn and hadoop-mr-client at top level seems very odd
[12:14pm] acmurthy: miscommunication
[12:14pm] tucu: still, logically still it is hierarchical, the names imply that. and IDEs
(eclipse and idea) show modules flat, regardless of the hierachy. And Maven resolves the dependencies
correctly as the hierachy is nothing for it
[12:19pm] acmurthy: tucu - is it hard to do it fullly heirarchical?
[12:19pm] acmurthy: having too many things at the top-level seems confusing for folks wihtout
[12:19pm] acmurthy: i liked your prev. proposal (aggregator modules) much better
[12:21pm] tucu: it is not hard, but i'd argue it is easier to work on a flat structure, ie
to move file around, you'll always be at the same depth (*/src/main/java/). If you see big
projects using maven the tent to use a flat set of modules.
[12:21pm] tucu: and in the past, maven was not fully functional with multi-level stuff
[12:22pm] tucu: now it is not the case, but some plugins may go bonkers
[12:22pm] tucu: and the fact that IDEs show thigns flat, is easy for a devel to do things
from both environments
[12:22pm] tucu: without getting lost
[12:25pm] acmurthy: i'd really prefer heirarchical
[12:25pm] acmurthy: the project is truly heirarchical: common, hdfs, mr
[12:25pm] acmurthy: and so n
[12:25pm] acmurthy: on*
[12:28pm] tucu: arun, let me work on a patch for hierachical approach and then we can discuss
the merits of both

> Make hadoop-common a POM module with sub-modules (common & alfredo)
> -------------------------------------------------------------------
>                 Key: HADOOP-7560
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7560
>             Project: Hadoop Common
>          Issue Type: Sub-task
>            Reporter: Alejandro Abdelnur
>            Assignee: Alejandro Abdelnur
>             Fix For: 0.23.0
>         Attachments: HADOOP-7560v1.patch, HADOOP-7560v1.sh
> Currently hadoop-common is a JAR module, thus it cannot aggregate sub-modules.
> Changing it to POM module it makes it an aggregator module, all the code under hadoop-common
must be moved to a sub-module.
> I.e.:
> mkdir hadoop-common-project
> mv hadoop-common hadoop-common-project
> mv hadoop-alfredo hadoop-common-project
> hadoop-common-project/pom.xml is a POM module that aggregates common & alfredo

This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message