hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Douglas (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7573) hadoop should log configuration reads
Date Tue, 23 Aug 2011 22:03:29 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13089802#comment-13089802
] 

Chris Douglas commented on HADOOP-7573:
---------------------------------------

I'm not sure this is going to be helpful given common usage of that class... the patch tracks
the first time each _instance_ of a {{Configuration}} accesses a property; these instances
are often duplicated from a template, etc.

At a minimum, adding a separate logger and/or decreasing to DEBUG or even TRACE, then guarding
the call to {{reportOptionRead}} behind {{isDebugEnabled}} would at least decrease the noise
in the servers and user Tasks.

I'm skeptical that this change should be embedded so deeply in the framework, even with a
switch disabling it. It will be unintelligible to most users and developers roll their own
{{println}} debugging...

> hadoop should log configuration reads
> -------------------------------------
>
>                 Key: HADOOP-7573
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7573
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>    Affects Versions: 0.20.203.0
>            Reporter: Ari Rabkin
>            Assignee: Ari Rabkin
>            Priority: Minor
>             Fix For: 0.20.206.0
>
>         Attachments: HADOOP-7573.patch, HADOOP-7573.patch
>
>
> For debugging, it would often be valuable to know which configuration options ever got
read out of the Configuration into the rest of the program -- an unread option didn't cause
a problem. This patch logs the first time each option is read.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message