Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-issues@hadoop.apache.org
Date: Wed, 6 Jul 2011 01:40:16 +0000 (UTC)
From: "Eli Collins (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: 
 <1961419580.2436.1309916416732.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1627635793.7816.1309496248661.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HADOOP-7437) IOUtils.copybytes will suppress
 the stream closure exceptions.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-7437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13060230#comment-13060230 ] 

Eli Collins commented on HADOOP-7437:
-------------------------------------

Should't this fix all the copyBytes methods, not just one of them?

> IOUtils.copybytes will suppress the stream closure exceptions. 
> ---------------------------------------------------------------
>
>                 Key: HADOOP-7437
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7437
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: io
>    Affects Versions: hudson, 0.23.0
>            Reporter: Uma Maheswara Rao G
>            Assignee: Uma Maheswara Rao G
>             Fix For: 0.23.0
>
>         Attachments: HADOOP-7437.patch
>
>
> {code}
> public static void copyBytes(InputStream in, OutputStream out, long count,
>       boolean close) throws IOException {
>     byte buf[] = new byte[4096];
>     long bytesRemaining = count;
>     int bytesRead;
>     try {
>       .............
>       .............
>     } finally {
>       if (close) {
>         closeStream(out);
>         closeStream(in);
>       }
>     }
>   }
> {code}
> Here if any exception in closing the stream, it will get suppressed here.
> So, better to follow the stream closure pattern as HADOOP-7194.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira