hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suresh Srinivas (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7460) Support for pluggable Trash policies
Date Fri, 15 Jul 2011 00:32:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13065635#comment-13065635

Suresh Srinivas commented on HADOOP-7460:

I took a quick look at it. Some comments:
# Trash.java
#* I prefer Trash uses/contains TrashPolicy insted Trash is TrashPolicy relationship. With
this Trash does not need to have incompatible changes or deprecation. Trash could use TrashPolicyFactory
to create a policy that it references. This also makes other code changes in this patch unnecessary.
#* Why are you making some members non final? You could call from one constructor another
constructor with this(...) and still keep it final without introducing initialize method?
#* There are empty changes (with just space added).
#* Indentation of Trash class definition is not quite right.
# TrashPolicy.java
#* Can Trash#fs, Trash#homeParent, Trash#deletionInterval and any other members be common
to all TrashPolicy and hence be moved to TrashPolicy?
#* Move factory methods out of TrashPolicy to a separate class TrashPolicyFactory?
#* What is the need to make TrashPolicy extend Configured?
#* I am not sure what checkpoint() method really does - the javadoc is quite vague. Is the
correct name snapshot for this? Is the right name for expunge() deleteSnapshots()?
#* It does not look like getEmptier() method is needed? Just a start method on Trash should
suffice right? Why expose emptier? Running the thread as part of Trash is better than trash

> Support for pluggable Trash policies
> ------------------------------------
>                 Key: HADOOP-7460
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7460
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs
>            Reporter: dhruba borthakur
>            Assignee: Usman Masood
>         Attachments: PluggableTrash.patch, PluggableTrash_V2.patch
> It would be beneficial to make the Trash policy pluggable. One primary use-case for this
is to archive files (in some remote store) when they get removed by Trash emptier.

This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message