hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Lipcon (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7328) Give more information about a missing Serializer class
Date Mon, 25 Jul 2011 21:18:09 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13070763#comment-13070763
] 

Todd Lipcon commented on HADOOP-7328:
-------------------------------------

A few small notes:
- rather than using assertTrue and assertFalse with == checks against null, use assertNull,
assertNotNull
- new tests should use the JUnit 4 API (not extend from TestCase)
- looks like there is some bad indentation in SerializationFactory.add
- this JIRA should probably be renamed to indicate its new purpose (ie returning null instead
of throwing NPE)

> Give more information about a missing Serializer class
> ------------------------------------------------------
>
>                 Key: HADOOP-7328
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7328
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: io
>    Affects Versions: 0.20.2
>            Reporter: Harsh J
>            Assignee: Harsh J
>              Labels: io, serialization
>             Fix For: 0.23.0
>
>         Attachments: HADOOP-7328.r1.diff, HADOOP-7328.r2.diff, HADOOP-7328.r3.diff, HADOOP-7328.r4.diff,
HADOOP-7328.r4.diff, HADOOP-7328.r5.diff, HADOOP-7328.r6.diff
>
>
> When you have a key/value class that's non Writable and you forget to attach io.serializers
for the same, an NPE is thrown by the tasks with no information on why or what's missing and
what led to it. I think a better exception can be thrown by SerializationFactory instead of
an NPE when a class is not found accepted by any of the loaded ones.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message