hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron T. Myers (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7455) Introduce HA Service Protocol Interface
Date Tue, 12 Jul 2011 02:11:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13063663#comment-13063663
] 

Aaron T. Myers commented on HADOOP-7455:
----------------------------------------

Thanks Suresh. This latest version makes a lot more sense. A few comments:

# I think the method name "{{monitor}}" could be more descriptive. Perhaps something like
"{{getAvailabilityState}}"?
# On that note, the method comment for "{{monitor}}" says "Monitor the health of the service,"
but the method isn't really monitoring "health" as much as it is just returning what state
the service is in. e.g. it could be a very healthy standby server. :)
# Are you at all concerned that the set of possible values of {{ServiceState}} might be too
restrictive? This is certainly the terminology and framework proposed for HDFS HA in HDFS-1623,
but if this protocol is truly to be a generic one that any HA service might implement, should
we not be more flexible/future-proof? (Note: I think the answer is probably that we should
cross that bridge when we come to it.)
# I think the name "{{ServiceException}}" and the associated class comment could be more descriptive.
Perhaps something like "{{ServiceAvailabilityException}}" ?

> Introduce HA Service Protocol Interface
> ---------------------------------------
>
>                 Key: HADOOP-7455
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7455
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: util
>            Reporter: Suresh Srinivas
>            Assignee: Suresh Srinivas
>         Attachments: HADOOP-7455.1.patch, HDFS-7454.patch
>
>
> This jira introduces a protocol interface to be implemented by services that provide
HA functionality.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message