hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uma Maheswara Rao G (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7460) Support for pluggable Trash policies
Date Sat, 16 Jul 2011 10:58:59 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13066402#comment-13066402
] 

Uma Maheswara Rao G commented on HADOOP-7460:
---------------------------------------------

Hi Usman,
 New patch looks good to me...good job!

There are some points to address:

 TrashPolicy.java
  1. unused variable.
    private static final Log LOG =
    LogFactory.getLog(TrashPolicy.class);
  

 Trash.java:
   1. unused imports are there. can you please remove them?

   2. I think previous Trash users can do setConf and getConf because it extends Configured.
But now any way to handle it? TrashPolicy extended it, but as per my understanding User will
deal with Trash only right.

   3.Also unused log variable.
   
 TrashPolicyDefault.java:

  1. Here also please clean the unused imports.

Also after attaching the patch, you need to Submit it.

> Support for pluggable Trash policies
> ------------------------------------
>
>                 Key: HADOOP-7460
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7460
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs
>            Reporter: dhruba borthakur
>            Assignee: Usman Masood
>         Attachments: PluggableTrash.patch, PluggableTrash_V2.patch, PluggableTrash_V3.patch
>
>
> It would be beneficial to make the Trash policy pluggable. One primary use-case for this
is to archive files (in some remote store) when they get removed by Trash emptier.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message