hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Doug Cutting (JIRA)" <j...@apache.org>
Subject [jira] [Issue Comment Edited] (HADOOP-7460) Support for pluggable Trash policies
Date Fri, 15 Jul 2011 00:04:02 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13065621#comment-13065621
] 

Doug Cutting edited comment on HADOOP-7460 at 7/15/11 12:03 AM:
----------------------------------------------------------------

This looks mostly reasonable to me.  A few nits:
- The TrashPolicy#getInstance() implementations need javadoc comments.
- TrashPolicy#getEmptier() should perhaps not claim that, "only one checkpoint is kept", as
not all implementations might implement that policy.
- Trash methods that override TrashPolicy methods should have an @Override and don't need
javadoc unless it's different than that inherited from TrashPolicy.

      was (Author: cutting):
    This looks mostly reasonable to me.  A few nits:
- the TrashPolicy#getInstance() implementations need javadoc comments.
- 
  
> Support for pluggable Trash policies
> ------------------------------------
>
>                 Key: HADOOP-7460
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7460
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs
>            Reporter: dhruba borthakur
>            Assignee: Usman Masood
>         Attachments: PluggableTrash.patch, PluggableTrash_V2.patch
>
>
> It would be beneficial to make the Trash policy pluggable. One primary use-case for this
is to archive files (in some remote store) when they get removed by Trash emptier.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message