Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B40456CB8 for ; Mon, 20 Jun 2011 20:13:11 +0000 (UTC) Received: (qmail 16797 invoked by uid 500); 20 Jun 2011 20:13:11 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 16756 invoked by uid 500); 20 Jun 2011 20:13:11 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 16681 invoked by uid 99); 20 Jun 2011 20:13:11 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 20 Jun 2011 20:13:11 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 20 Jun 2011 20:13:09 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 5B1EE425F1E for ; Mon, 20 Jun 2011 20:12:48 +0000 (UTC) Date: Mon, 20 Jun 2011 20:12:48 +0000 (UTC) From: "monica beckwith (JIRA)" To: common-issues@hadoop.apache.org Message-ID: <709150972.22413.1308600768370.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1229925666.15226.1308324167811.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Updated] (HADOOP-7401) Unit test TestPureJavaCRC32 warmup code warms up the not-so-important loop in PureJavaCRC32.update() MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HADOOP-7401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] monica beckwith updated HADOOP-7401: ------------------------------------ Status: Patch Available (was: Open) > Unit test TestPureJavaCRC32 warmup code warms up the not-so-important loop in PureJavaCRC32.update() > ---------------------------------------------------------------------------------------------------- > > Key: HADOOP-7401 > URL: https://issues.apache.org/jira/browse/HADOOP-7401 > Project: Hadoop Common > Issue Type: Improvement > Components: test > Affects Versions: 0.21.0 > Environment: Solaris-Sparcv9; Solaris-AMD64 > Reporter: monica beckwith > Assignee: monica beckwith > Priority: Minor > Fix For: 0.21.0 > > Attachments: hadoop-7401.patch > > Original Estimate: 1m > Remaining Estimate: 1m > > When the warmup code sequence in TestPureJavaCRC32.java is executed, it sends size=len=2 and due to the value of 'trials' in for loop in doBench(), the crc.update() gets run > the compile threshold, thus providing the information that 'while 07' is a cold loop. This brings the MB/s number for len > 7 in PureJavaCRC32.update() way down (e.g. ~28.5% for size=len=65536). > The workaround would be to use size=len=>7 (so just having size=len=2101 ahead of size=len=2 will do the trick) in the warmup section. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira