Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BFC646D40 for ; Thu, 2 Jun 2011 00:53:28 +0000 (UTC) Received: (qmail 80341 invoked by uid 500); 2 Jun 2011 00:53:28 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 80262 invoked by uid 500); 2 Jun 2011 00:53:28 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 80197 invoked by uid 99); 2 Jun 2011 00:53:28 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 Jun 2011 00:53:28 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 Jun 2011 00:53:27 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 73657EF445 for ; Thu, 2 Jun 2011 00:52:47 +0000 (UTC) Date: Thu, 2 Jun 2011 00:52:47 +0000 (UTC) From: "Todd Lipcon (JIRA)" To: common-issues@hadoop.apache.org Message-ID: <43396362.61498.1306975967469.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <647927887.58055.1306890116067.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Updated] (HADOOP-7346) Send back nicer error to clients using outdated IPC version MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-7346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Todd Lipcon updated HADOOP-7346: -------------------------------- Attachment: hadoop-7346.txt I couldn't think of any way to do it with mocks, so I did brute force and wrote some tests which just replay RPC traces that I captured by hand from 0.18.3, branch-0.20, and 0.21.0. They then verify that the response matches my captured response (which I verified generated a reasonable exception on the client) > Send back nicer error to clients using outdated IPC version > ----------------------------------------------------------- > > Key: HADOOP-7346 > URL: https://issues.apache.org/jira/browse/HADOOP-7346 > Project: Hadoop Common > Issue Type: Improvement > Components: ipc > Affects Versions: 0.22.0 > Reporter: Todd Lipcon > Assignee: Todd Lipcon > Fix For: 0.22.0 > > Attachments: hadoop-7346.txt, hadoop-7346.txt > > > When an older Hadoop version tries to contact a newer Hadoop version across an IPC protocol version bump, the client currently just gets a non-useful error message like "EOFException". > Instead, the IPC server code can speak just enough of prior IPC protocols to send back a "fatal" message indicating the version mismatch. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira