Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 571D64110 for ; Sat, 11 Jun 2011 00:31:20 +0000 (UTC) Received: (qmail 30401 invoked by uid 500); 11 Jun 2011 00:31:20 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 30375 invoked by uid 500); 11 Jun 2011 00:31:19 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 30367 invoked by uid 99); 11 Jun 2011 00:31:19 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 11 Jun 2011 00:31:19 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 11 Jun 2011 00:31:18 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id D1D4610E65B for ; Sat, 11 Jun 2011 00:30:58 +0000 (UTC) Date: Sat, 11 Jun 2011 00:30:58 +0000 (UTC) From: "Todd Lipcon (JIRA)" To: common-issues@hadoop.apache.org Message-ID: <1903769667.13020.1307752258856.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <55510245.12688.1307747698852.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Updated] (HADOOP-7379) Add ability to include Protobufs in ObjectWritable MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-7379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Todd Lipcon updated HADOOP-7379: -------------------------------- Attachment: hadoop-7379.txt Here's a patch which does the following: - protobufs can be serialized by ObjectWritable. They are length-prefixed with a varint and then written on the wire - adds test for the writable format itself - adds a call in TestIPC that uses a protobuf as a parameter and response I see one spot for an optimization by removing a buffer copy on the read side, but I'd like to leave that for later. > Add ability to include Protobufs in ObjectWritable > -------------------------------------------------- > > Key: HADOOP-7379 > URL: https://issues.apache.org/jira/browse/HADOOP-7379 > Project: Hadoop Common > Issue Type: Improvement > Components: io, ipc > Affects Versions: 0.23.0 > Reporter: Todd Lipcon > Assignee: Todd Lipcon > Fix For: 0.23.0 > > Attachments: hadoop-7379.txt > > > Per HDFS-2060, it would make it easier to piecemeal switch to protocol buffer based data structures in the wire protocol if we could intermix the two. The IPC framework currently provides the concept of "engines" for RPC, but that doesn't easily allow mixed types within the same framework for ease of transition. > I'd like to add the cases to ObjectWritable to be handle subclasses of {{Message}}, the superclass of codegenned protobufs. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira