Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 438D86DA9 for ; Wed, 1 Jun 2011 11:16:31 +0000 (UTC) Received: (qmail 32392 invoked by uid 500); 1 Jun 2011 11:16:31 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 32354 invoked by uid 500); 1 Jun 2011 11:16:31 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 32345 invoked by uid 99); 1 Jun 2011 11:16:31 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Jun 2011 11:16:31 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Jun 2011 11:16:28 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 81CDAED79D for ; Wed, 1 Jun 2011 11:15:47 +0000 (UTC) Date: Wed, 1 Jun 2011 11:15:47 +0000 (UTC) From: "Hudson (JIRA)" To: common-issues@hadoop.apache.org Message-ID: <1273325975.59239.1306926947527.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1195662636.6130.1300891805766.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HADOOP-7208) equals() and hashCode() implementation need to change in StandardSocketFactory MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HADOOP-7208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042109#comment-13042109 ] Hudson commented on HADOOP-7208: -------------------------------- Integrated in Hadoop-Common-trunk #706 (See [https://builds.apache.org/hudson/job/Hadoop-Common-trunk/706/]) HADOOP-7208. Fix implementation of equals() and hashCode() in StandardSocketFactory. Contributed by Uma Maheswara Rao G. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1129840 Files : * /hadoop/common/trunk/CHANGES.txt * /hadoop/common/trunk/src/test/core/org/apache/hadoop/ipc/TestSocketFactory.java * /hadoop/common/trunk/src/java/org/apache/hadoop/net/StandardSocketFactory.java > equals() and hashCode() implementation need to change in StandardSocketFactory > ------------------------------------------------------------------------------ > > Key: HADOOP-7208 > URL: https://issues.apache.org/jira/browse/HADOOP-7208 > Project: Hadoop Common > Issue Type: Bug > Affects Versions: 0.23.0 > Reporter: Uma Maheswara Rao G > Assignee: Uma Maheswara Rao G > Fix For: 0.23.0 > > Attachments: HADOOP-7208-2.patch, HADOOP-7208-3.patch, HADOOP-7208.patch > > > In Hadoop IPC Client, we are using ClientCache which will maintain the HashMap to keep the Client references. > private Map clients = > new HashMap(); > Now let us say, we want use two standard factories with Hadoop. MyStandardSocketFactory (which extends StandardSocketFactory), and StandardSocketFactory. In this case, because of equals and hashcode implementation, MyStandardSocketFactory client can be overridden by StandardSocketFactoryClient -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira