Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-issues@hadoop.apache.org
Date: Wed, 1 Jun 2011 00:26:48 +0000 (UTC)
From: "Luke Lu (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: 
 <1136514016.57917.1306888008042.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1728703995.16605.1297739397760.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HADOOP-7144) Expose JMX with something like
 JMXProxyServlet
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-7144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13041907#comment-13041907 ] 

Luke Lu commented on HADOOP-7144:
---------------------------------

LOG.error is always called before handleThrowable. It looked reasonable (it's not swallowing all throwables and log the errors) to me at the time, as we should never let jetty handle the exceptions/errors as stack traces would be display as part of the result, which is a security no no.

OTOH, I think the logging should be handled by handleThrowable calls for better readability and DRYness.

Looking closely though, I found follow correctness issues:

# content type should be set to "application/json; charset=utf8"
# need to response.setStatus(response.SC_INTERNAL_SERVER_ERROR) for all error cases


> Expose JMX with something like JMXProxyServlet 
> -----------------------------------------------
>
>                 Key: HADOOP-7144
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7144
>             Project: Hadoop Common
>          Issue Type: New Feature
>            Reporter: Luke Lu
>            Assignee: Robert Joseph Evans
>              Labels: jmx
>             Fix For: 0.23.0
>
>         Attachments: HADOOP-7411-0.20.20X-V1.patch, HADOOP-7411-trunk-V1.patch, HADOOP-7411-trunk-alpha.patch, jmx.json
>
>
> Much of the Hadoop metrics and status info is available via JMX, especially since 0.20.100, and 0.22+ (HDFS-1318, HADOOP-6728 etc.) For operations staff not familiar JMX setup, especially JMX with SSL and firewall tunnelling, the usage can be daunting. Using a JMXProxyServlet (a la Tomcat) to translate JMX attributes into JSON output would make a lot of non-Java admins happy.
> We could probably use Tomcat's JMXProxyServlet code directly, if it's already output some standard format (JSON or XML etc.) The code is simple enough to port over and can probably integrate with the common HttpServer as one of the default servelet (maybe /jmx) for the pluggable security.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira