hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron T. Myers (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7341) Fix option parsing in CommandFormat
Date Fri, 03 Jun 2011 22:20:47 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13044092#comment-13044092
] 

Aaron T. Myers commented on HADOOP-7341:
----------------------------------------

+1, looks good to me.

One nit: I'd recommend either removing the "@deprecated name is never used" from the comment,
or changing the name of the parameter from "n" to "name". Outside of the context of this patch,
the comment doesn't make much sense.

> Fix option parsing in CommandFormat
> -----------------------------------
>
>                 Key: HADOOP-7341
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7341
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>    Affects Versions: 0.23.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>         Attachments: HADOOP-7341-2.patch, HADOOP-7341.patch
>
>
> CommandFormat currently allows options in any location within the args.  This is not
the intended behavior for FsShell commands.  Prior to the redesign, the commands used to expect
option processing to stop at the first non-option.
> CommandFormat was an existing class prior the redesign, but it was only used by "count"
to find the -q flag.  All commands were converted to using this class, thus inherited the
unintended behavior.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message