hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daryn Sharp (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7348) Modify the option of FsShell getmerge from [addnl] to [-nl] for more comprehensive
Date Wed, 01 Jun 2011 15:22:47 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042227#comment-13042227
] 

Daryn Sharp commented on HADOOP-7348:
-------------------------------------

I see you beat me to removing my TODO, nice!  I'd suggest using a tertiary for assignment,
but that's just me, so up to you:
{code}delimiter = cf.getOpt("nl") ? "\n" : null;{code}

Please update the DESCRIPTION to include the {{-nl}} option, update the text in TestCLI, and
update the hdfs tests (link the jira to this one).  The applicable tests will be in TestDFSShell
and/or TestHDFSCLI.


> Modify the option of FsShell getmerge from [addnl] to [-nl] for more comprehensive
> ----------------------------------------------------------------------------------
>
>                 Key: HADOOP-7348
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7348
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs
>    Affects Versions: 0.23.0
>            Reporter: XieXianshan
>            Assignee: XieXianshan
>             Fix For: 0.23.0
>
>         Attachments: HADOOP-7348.patch
>
>
> The [addnl] option of FsShell getmerge should be either "true" or "false",but it is very
hard to understand by users, especially  who`s never used this option before. 
> So,the [addnl] option should be changed to [-nl] for more comprehensive.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message