hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Eagles (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7435) Make pre-commit checks run against the correct branch
Date Thu, 30 Jun 2011 19:20:28 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13058008#comment-13058008
] 

Jonathan Eagles commented on HADOOP-7435:
-----------------------------------------

Thanks, Aaron for this great idea. Here are some of my thoughts on this.

Having patch file naming convention would allow for some interesting use cases. Though a simple
version of this patch naming scheme would be a great addition, here is a full blown implementation
I was thinking about.

<ISSUE-#>-<full branch name>-v<version #>.patch

(e.g. MAPREDUCE-2569-MR-279-v2.patch)

- This naming scheme makes the patch completely stand-alone, allowing for emailing the patch
- Sanity of managing multiple patch files simultaneously in dev env
- Programmatic detection of which branch to apply
- Versioning of patches helps those who are submitting and testing out patches, and prevents
hudson/jenkins from applying several versions of the same patch and instead tests only the
latest version of the patch.
- JIRA attach file pre-commit detects "*.patch" and verifies patch naming convention.

Personally, I do not prefer to overload "Fix version/s" since that implies what branches the
patch is already committed to, leading to confusion. Additionally, newbie hadoop developers
may be able to attach files to issues, but are not allowed to edit issue fields.

> Make pre-commit checks run against the correct branch
> -----------------------------------------------------
>
>                 Key: HADOOP-7435
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7435
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.23.0
>            Reporter: Aaron T. Myers
>             Fix For: 0.23.0
>
>
> The Hudson pre-commit tests are presently only capable of testing a patch against trunk.
It'd be nice if this could be extended to automatically run against the correct branch.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message