hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7351) Regression: HttpServer#getWebAppsPath used to be protected so subclasses could supply alternate webapps path but it was made private by HADOOP-6461
Date Thu, 02 Jun 2011 17:08:47 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042886#comment-13042886
] 

stack commented on HADOOP-7351:
-------------------------------

Sounds fine to me.  Want me to add this to patch?

> Regression: HttpServer#getWebAppsPath used to be protected so subclasses could supply
alternate webapps path but it was made private by HADOOP-6461
> ---------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7351
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7351
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: stack
>            Assignee: stack
>         Attachments: 7351.txt
>
>
> It USED to be protected rather than private but its access was changed by HADOOP-6461.
 It did the following:
> {code}
> -  protected String getWebAppsPath() throws IOException {
> -    URL url = getClass().getClassLoader().getResource("webapps");
> +  private String getWebAppsPath(String appName) throws FileNotFoundException {
> +    URL url = getClass().getClassLoader().getResource("webapps/" + appName);
> ...
> {code}
> HBase subclasses HttpServer providing its UI.  This change makes it so we can no longer
do so.
> This change made it into 0.21.  I'd like to get a fix committed to 0.22 as well as TRUNK.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message