hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7328) Give more information about a missing Serializer class
Date Thu, 16 Jun 2011 12:13:49 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13050373#comment-13050373

jiraposter@reviews.apache.org commented on HADOOP-7328:

This is an automatically generated e-mail. To reply, visit:

(Updated 2011-06-16 12:13:34.081758)

Review request for hadoop-common and Todd Lipcon.


Throw exceptions (getting rid of nulls). Add appropriate javadocs and fix one checkstyle nit.


Since getSerialization() can possibly return a null, it is only right that getSerializer()
and getDeserializer() usage functions do the same, instead of throwing up NPEs.

Related issue to which this improvement is required: https://issues.apache.org/jira/browse/MAPREDUCE-2584

This addresses bug HADOOP-7328.

Diffs (updated)

  src/java/org/apache/hadoop/io/serializer/SerializationFactory.java dee314a 

Diff: https://reviews.apache.org/r/884/diff


Existing SequenceFile serialization factory tests pass. The change is merely to make the functions
return null instead of throwing an NPE within.



> Give more information about a missing Serializer class
> ------------------------------------------------------
>                 Key: HADOOP-7328
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7328
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: io
>    Affects Versions: 0.20.2
>            Reporter: Harsh J
>            Assignee: Harsh J
>              Labels: io, serialization
>             Fix For: 0.23.0
>         Attachments: HADOOP-7328.r1.diff, HADOOP-7328.r2.diff
> When you have a key/value class that's non Writable and you forget to attach io.serializers
for the same, an NPE is thrown by the tasks with no information on why or what's missing and
what led to it. I think a better exception can be thrown by SerializationFactory instead of
an NPE when a class is not found accepted by any of the loaded ones.

This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message