hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brock Noland (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HADOOP-310) Additional constructor requested in BytesWritable
Date Sun, 26 Jun 2011 10:34:47 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Brock Noland updated HADOOP-310:
--------------------------------

    Attachment: bytes-writable-zero-copy-interface-2.patch

Great points. The attached removes the set method which would have been confusing. This is
what the original JIRA request was for.

I do not see any need for the set method I had previously written. If you compare the cost
of creating of an additional object, due to no zero copy set, versus being required to perform
a copy to fill the BW, the extra object should be negligible with a byte array of any size.

> Additional constructor requested in BytesWritable
> -------------------------------------------------
>
>                 Key: HADOOP-310
>                 URL: https://issues.apache.org/jira/browse/HADOOP-310
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: io
>            Reporter: p sutter
>            Assignee: Owen O'Malley
>            Priority: Minor
>         Attachments: bytes-writable-zero-copy-interface-0.patch, bytes-writable-zero-copy-interface-1.patch,
bytes-writable-zero-copy-interface-2.patch
>
>
> It would be grand if BytesWritable.java had an additional constructor as below. This
allows me to use the BytesWritable class without doing a buffer copy, since we have a less-than-fully-utilized
byte array holding our key.
> Thanks!
>  
>  /**
>    * Create a BytesWritable using the byte array as the initial value.
>    * @param bytes This array becomes the backing storage for the object.
>    */
>   public BytesWritable(byte[] bytes, int size) {
>     this.bytes = bytes;
>     this.size = size;
>   }
>   

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message