hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HADOOP-7351) Regression: HttpServer#getWebAppsPath used to be protected so subclasses could supply alternate webapps path but it was made private by HADOOP-6461
Date Thu, 02 Jun 2011 19:11:47 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-7351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

stack updated HADOOP-7351:
--------------------------

       Resolution: Fixed
    Fix Version/s: 0.22.0
     Hadoop Flags: [Reviewed]
           Status: Resolved  (was: Patch Available)

Committed to 0.22 branch and to TRUNK.  Thanks for review Todd.

This small change makes it so HBase does not have to redo how it does its UI when it runs
against hadoop 0.22; we subclass HttpServer so we can have the 'log level', 'thread dump',
etc., servlets available in HBase UI. 

> Regression: HttpServer#getWebAppsPath used to be protected so subclasses could supply
alternate webapps path but it was made private by HADOOP-6461
> ---------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7351
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7351
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: stack
>            Assignee: stack
>             Fix For: 0.22.0
>
>         Attachments: 7351.txt
>
>
> It USED to be protected rather than private but its access was changed by HADOOP-6461.
 It did the following:
> {code}
> -  protected String getWebAppsPath() throws IOException {
> -    URL url = getClass().getClassLoader().getResource("webapps");
> +  private String getWebAppsPath(String appName) throws FileNotFoundException {
> +    URL url = getClass().getClassLoader().getResource("webapps/" + appName);
> ...
> {code}
> HBase subclasses HttpServer providing its UI.  This change makes it so we can no longer
do so.
> This change made it into 0.21.  I'd like to get a fix committed to 0.22 as well as TRUNK.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message