hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7384) Allow test-patch to be more flexible about patch format
Date Tue, 14 Jun 2011 01:24:47 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13048932#comment-13048932
] 

Hadoop QA commented on HADOOP-7384:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12482315/hadoop-7384.txt
  against trunk revision 1135333.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 7 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 system test framework.  The patch passed system test framework compile.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/620//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/620//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/620//console

This message is automatically generated.

> Allow test-patch to be more flexible about patch format
> -------------------------------------------------------
>
>                 Key: HADOOP-7384
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7384
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 0.23.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>         Attachments: hadoop-7384.txt
>
>
> Right now the test-patch process only accepts patches that are generated as "-p0" relative
to common/, hdfs/, or mapreduce/. This has always been annoying for git users where the default
patch format is -p1. It's also now annoying for SVN users who may generate a patch relative
to trunk/ instead of the subproject subdirectory. We should auto-detect the correct patch
level.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message