hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-310) Additional constructor requested in BytesWritable
Date Mon, 27 Jun 2011 03:04:47 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13055303#comment-13055303
] 

Hadoop QA commented on HADOOP-310:
----------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12483841/bytes-writable-zero-copy-interface-2.patch
  against trunk revision 1139947.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 system test framework.  The patch passed system test framework compile.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/677//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/677//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/677//console

This message is automatically generated.

> Additional constructor requested in BytesWritable
> -------------------------------------------------
>
>                 Key: HADOOP-310
>                 URL: https://issues.apache.org/jira/browse/HADOOP-310
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: io
>            Reporter: p sutter
>            Assignee: Brock Noland
>            Priority: Minor
>         Attachments: bytes-writable-zero-copy-interface-0.patch, bytes-writable-zero-copy-interface-1.patch,
bytes-writable-zero-copy-interface-2.patch
>
>
> It would be grand if BytesWritable.java had an additional constructor as below. This
allows me to use the BytesWritable class without doing a buffer copy, since we have a less-than-fully-utilized
byte array holding our key.
> Thanks!
>  
>  /**
>    * Create a BytesWritable using the byte array as the initial value.
>    * @param bytes This array becomes the backing storage for the object.
>    */
>   public BytesWritable(byte[] bytes, int size) {
>     this.bytes = bytes;
>     this.size = size;
>   }
>   

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message