hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Lipcon (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7362) Create a Lock annotation to document locking (hierarchies) for methods
Date Tue, 07 Jun 2011 17:00:59 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045536#comment-13045536
] 

Todd Lipcon commented on HADOOP-7362:
-------------------------------------

I like the idea of using JCIP where possible, especially for its documentation value.

But in code paths that aren't hot/performance sensitive, please let's not rely on things like
static analysis and @CheckForNull to catch bugs. Good old fashioned asserts and checks like
Preconditions.checkNotNull() have the nice side effect that anyone running tests will find
the bug, and you can't just ignore it like you can static analysis results :)

> Create a Lock annotation to document locking (hierarchies) for methods
> ----------------------------------------------------------------------
>
>                 Key: HADOOP-7362
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7362
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Arun C Murthy
>            Assignee: Arun C Murthy
>
> It will be useful to have better developer docs via a Lock annotation to document locking
(hierarchies) for methods.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message