hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Plush (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7135) Commit 949660 broke FileUtil.copyMerge
Date Sat, 25 Jun 2011 19:13:47 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13054955#comment-13054955
] 

Jim Plush commented on HADOOP-7135:
-----------------------------------

This appears to be fixed in trunk
FileUtil.copyMerge method now shows:

 dstFile = checkDest(srcDir.getName(), dstFS, dstFile, false);

    if (!srcFS.getFileStatus(srcDir).isDirectory())
      return false;
   
    OutputStream out = dstFS.create(dstFile);

> Commit 949660 broke FileUtil.copyMerge
> --------------------------------------
>
>                 Key: HADOOP-7135
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7135
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>    Affects Versions: 0.21.0
>            Reporter: Jeffrey Gerard
>   Original Estimate: 5m
>  Remaining Estimate: 5m
>
> Looking at http://svn.apache.org/viewvc/hadoop/common/branches/branch-0.21/src/java/org/apache/hadoop/fs/FileUtil.java?r1=949659&r2=949660&
> it seems this commit broke FileUtil.copyMerge by omitting NOT operator.  copyMerge only
makes sense if srcDir is a directory.
> Should be
>     if (!srcFS.getFileStatus(srcDir).isDirectory())
>        return false;

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message