hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7351) Regression: HttpServer#getWebAppsPath used to be protected so subclasses could supply alternate webapps path but it was made private by HADOOP-6461
Date Thu, 02 Jun 2011 06:24:47 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042623#comment-13042623
] 

Hadoop QA commented on HADOOP-7351:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12481198/7351.txt
  against trunk revision 1129989.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 system test framework.  The patch passed system test framework compile.

Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/559//testReport/
Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/559//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/559//console

This message is automatically generated.

> Regression: HttpServer#getWebAppsPath used to be protected so subclasses could supply
alternate webapps path but it was made private by HADOOP-6461
> ---------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7351
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7351
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: stack
>            Assignee: stack
>         Attachments: 7351.txt
>
>
> It USED to be protected rather than private but its access was changed by HADOOP-6461.
 It did the following:
> {code}
> -  protected String getWebAppsPath() throws IOException {
> -    URL url = getClass().getClassLoader().getResource("webapps");
> +  private String getWebAppsPath(String appName) throws FileNotFoundException {
> +    URL url = getClass().getClassLoader().getResource("webapps/" + appName);
> ...
> {code}
> HBase subclasses HttpServer providing its UI.  This change makes it so we can no longer
do so.
> This change made it into 0.21.  I'd like to get a fix committed to 0.22 as well as TRUNK.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message