Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-issues@hadoop.apache.org
Date: Tue, 31 May 2011 15:34:50 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: 
 <2076075170.56366.1306856090979.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: <18917644.179531294294848031.JavaMail.jira@thor>
Subject: [jira] [Commented] (HADOOP-7090) Possible resource leaks in hadoop
 core code
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-7090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13041631#comment-13041631 ] 

Hadoop QA commented on HADOOP-7090:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12480947/HADOOP-7090.0.patch
  against trunk revision 1128789.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 system test framework.  The patch passed system test framework compile.

Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/544//testReport/
Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/544//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/544//console

This message is automatically generated.

> Possible resource leaks in hadoop core code
> -------------------------------------------
>
>                 Key: HADOOP-7090
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7090
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.21.0, 0.23.0
>            Reporter: Gokul
>         Attachments: HADOOP-7090.0.patch
>
>
> It is always a good practice to close the IO streams in a finally block.. 
> For example, look at the following piece of code in the Writer class of BloomMapFile 
> {code:title=BloomMapFile .java|borderStyle=solid}
>     public synchronized void close() throws IOException {
>       super.close();
>       DataOutputStream out = fs.create(new Path(dir, BLOOM_FILE_NAME), true);
>       bloomFilter.write(out);
>       out.flush();
>       out.close();
>     }
> {code} 
> If an exception occurs during fs.create or on any other line,  out.close() will not be executed..
> The following can reduce the scope of resorce leaks..
> {code:title=BloomMapFile .java|borderStyle=solid}
>     public synchronized void close() throws IOException {
>       super.close();
>       DataOutputStream out = null;
>       try{
>           out = fs.create(new Path(dir, BLOOM_FILE_NAME), true);
>           bloomFilter.write(out);
>           out.flush();
>       }finally{
> 	 IOUtils.closeStream(out);
>     }
> {code} 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira