Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-issues@hadoop.apache.org
Date: Wed, 25 May 2011 00:32:47 +0000 (UTC)
From: "Bharath Mundlapudi (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: 
 <1932253256.41056.1306283567535.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1067116917.37592.1306187867429.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Updated] (HADOOP-7322) Adding a util method in FileUtil for
 directory listing
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/HADOOP-7322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bharath Mundlapudi updated HADOOP-7322:
---------------------------------------

    Attachment: HADOOP-7322-2.patch

Thanks for the comments, Matt. 

Regarding 2: Yes, we can be forgiving on this case. I added this because of eliminating null check. 

Attaching a patch which addresses all these comments. 

> Adding a util method in FileUtil for directory listing
> ------------------------------------------------------
>
>                 Key: HADOOP-7322
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7322
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Bharath Mundlapudi
>            Assignee: Bharath Mundlapudi
>            Priority: Minor
>             Fix For: 0.23.0
>
>         Attachments: HADOOP-7322-1.patch, HADOOP-7322-2.patch
>
>
> While testing Disk Fail Inplace, we encountered lots of NPE from Dir.listFiles API. This API can return null when Dir is not directory or disk is bad. I am proposing to have a File Util which can be used consistently across to deal with disk issues. This util api will do the following:
> 1. When error happens it will throw IOException
> 2. Else it will return empty list or list of files.
> Signature:
> File[] FileUtil.listFiles(File dir) throws IOException {}
> This way we no need to write wrapper code every where. Also, API is consistent with the signature.
>  

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira