Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-issues@hadoop.apache.org
Date: Wed, 4 May 2011 16:40:03 +0000 (UTC)
From: "Matt Foley (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: 
 <1257697462.22009.1304527203232.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <720022722.11722.1304088663379.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HADOOP-7251) Refactor FsShell's getmerge
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13028816#comment-13028816 ] 

Matt Foley commented on HADOOP-7251:
------------------------------------

I understand that the lifetime of the Merge object is only a single invocation, but I would prefer to have Merge.delimiter conditionally set to either null or "\n" at the decision point in processOptions(), in addition to being initialized to null by ctor.  It's just to remove concern about re-use, or in case the object ever changes to be re-used.

> Refactor FsShell's getmerge
> ---------------------------
>
>                 Key: HADOOP-7251
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7251
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs
>    Affects Versions: 0.23.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>         Attachments: HADOOP-7251.patch
>
>
> Need to refactor getmerge to conform to new FsCommand class.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira