Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6077C3165 for ; Fri, 6 May 2011 05:10:47 +0000 (UTC) Received: (qmail 82914 invoked by uid 500); 6 May 2011 05:10:47 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 82710 invoked by uid 500); 6 May 2011 05:10:47 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 82627 invoked by uid 99); 6 May 2011 05:10:45 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 06 May 2011 05:10:45 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 06 May 2011 05:10:42 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 2C8F8C3956 for ; Fri, 6 May 2011 05:10:03 +0000 (UTC) Date: Fri, 6 May 2011 05:10:03 +0000 (UTC) From: "Eli Collins (JIRA)" To: common-issues@hadoop.apache.org Message-ID: <1031760231.27176.1304658603179.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1594670430.14027.1299867839776.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Updated] (HADOOP-7183) WritableComparator.get should not cache comparator objects MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HADOOP-7183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eli Collins updated HADOOP-7183: -------------------------------- Resolution: Fixed Fix Version/s: (was: 0.20.3) Hadoop Flags: [Reviewed] Status: Resolved (was: Patch Available) I've committed this to trunk, branch 22, and branch 21. Thanks Tom! > WritableComparator.get should not cache comparator objects > ---------------------------------------------------------- > > Key: HADOOP-7183 > URL: https://issues.apache.org/jira/browse/HADOOP-7183 > Project: Hadoop Common > Issue Type: Bug > Affects Versions: 0.22.0 > Reporter: Todd Lipcon > Assignee: Tom White > Priority: Blocker > Fix For: 0.21.1, 0.22.0 > > Attachments: HADOOP-7183.patch, HADOOP-7183.patch > > > HADOOP-6881 modified WritableComparator.get such that the constructed WritableComparator gets saved back into the static map. This is fine for stateless comparators, but some comparators have per-instance state, and thus this becomes thread-unsafe and causes errors in the shuffle where multiple threads are doing comparisons. An example of a Comparator with per-instance state is WritableComparator itself. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira