hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo (Nicholas), SZE (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7334) test-patch should check for hard tabs
Date Fri, 27 May 2011 02:07:47 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13040029#comment-13040029
] 

Tsz Wo (Nicholas), SZE commented on HADOOP-7334:
------------------------------------------------

Nice work!  We should have this long time ago.

BTW, do you want to also check 80 characters per line?  But it is arguably if it is the rule
we want to enforce.

> test-patch should check for hard tabs
> -------------------------------------
>
>                 Key: HADOOP-7334
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7334
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build, test
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Minor
>         Attachments: hadoop-7334.txt, hadoop-7334.txt
>
>
> Our coding guidelines say that hard tabs are disallowed in the Hadoop code, but they
sometimes sneak in (there are about 280 in the common codebase at the moment).
> We should run a simple check for this in the test-patch process so it's harder for them
to sneak in.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message