hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron T. Myers (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7286) Refactor FsShell's du/dus/df
Date Mon, 16 May 2011 21:50:47 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13034353#comment-13034353
] 

Aaron T. Myers commented on HADOOP-7286:
----------------------------------------

Latest patch looks to be almost there. A few nits:

# Comment in {{FsUsage.java}} still references "viewing capacity." You also might as well
explicitly say something like "this is the base class for the {{df}} and {{du}} commands.
# I think the {{deprecatedFor(...)}} interface could be clearer. I think "{{boolean isDeprecated(...)}}"
and something like "{{String getPreferredCommand(...)}}" would be a lot quicker to understand.

> Refactor FsShell's du/dus/df
> ----------------------------
>
>                 Key: HADOOP-7286
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7286
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs
>    Affects Versions: 0.23.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>         Attachments: HADOOP-7286-2.patch, HADOOP-7286-3.patch, HADOOP-7286.patch
>
>
> Need to refactor to conform to FsCommand subclass.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message