hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matt Foley (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7146) RPC server leaks file descriptors
Date Tue, 24 May 2011 22:31:47 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13038865#comment-13038865
] 

Matt Foley commented on HADOOP-7146:
------------------------------------

bq. I didn't add null checks - the variables in question are never reassigned to null, so
there's no way they could be, as far as I can tell.

Quite right. To safeguard that, could you please make those two variables "final"?

Minor: In Reader.doRunLoop(), the LOG.Info() could use ", e" instead of "+ StringUtils.stringifyException(e)"

+1 if those small changes are okay with you.

> RPC server leaks file descriptors
> ---------------------------------
>
>                 Key: HADOOP-7146
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7146
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 0.22.0
>
>         Attachments: fd-leak.txt, hadoop-7146.txt, hadoop-7146.txt
>
>
> Both the Listener and Responder thread call Selector.open but don't have a matching .close().
This causes a leak of anonymous pipes. Not a big deal because people rarely close and re-open
servers, but worth fixing.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message