hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7227) Remove protocol version check at proxy creation in Hadoop RPC.
Date Tue, 03 May 2011 17:49:03 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13028342#comment-13028342
] 

Hadoop QA commented on HADOOP-7227:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12478070/HADOOP-7227.6.patch
  against trunk revision 1098840.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 9 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

    +1 system test framework.  The patch passed system test framework compile.

Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/394//testReport/
Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/394//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/394//console

This message is automatically generated.

> Remove protocol version check at proxy creation in Hadoop RPC.
> --------------------------------------------------------------
>
>                 Key: HADOOP-7227
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7227
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>            Reporter: Jitendra Nath Pandey
>            Assignee: Jitendra Nath Pandey
>             Fix For: 0.23.0
>
>         Attachments: HADOOP-7227.2.patch, HADOOP-7227.3.patch, HADOOP-7227.4.patch, HADOOP-7227.5.patch,
HADOOP-7227.6.patch
>
>
> Currently when a proxy is created for a protocol, there is a round trip of messages to
check the protocol version. The protocol version is not checked in any subsequent rpc which
could be a problem if the server restarts with a new protocol version. This issue and also
the additional round-trip at proxy creation can be avoided if we add the protocol version
in every rpc, and server checks the protocol version for every call.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message