hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7300) Configuration methods that return collections are inconsistent about mutability
Date Wed, 18 May 2011 18:44:47 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13035573#comment-13035573
] 

Hudson commented on HADOOP-7300:
--------------------------------

Integrated in Hadoop-Common-trunk-Commit #607 (See [https://builds.apache.org/hudson/job/Hadoop-Common-trunk-Commit/607/])
    HADOOP-7300. Configuration methods that return collections are inconsistent about mutability.
Contributed by Todd Lipcon.

todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1124368
Files : 
* /hadoop/common/trunk/src/test/core/org/apache/hadoop/conf/TestConfiguration.java
* /hadoop/common/trunk/CHANGES.txt
* /hadoop/common/trunk/src/java/org/apache/hadoop/conf/Configuration.java
* /hadoop/common/trunk/src/java/org/apache/hadoop/util/StringUtils.java


> Configuration methods that return collections are inconsistent about mutability
> -------------------------------------------------------------------------------
>
>                 Key: HADOOP-7300
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7300
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: conf
>    Affects Versions: 0.22.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 0.22.0
>
>         Attachments: hadoop-7300.txt
>
>
> In particular, getTrimmedStringCollection seems to return an immutable collection, whereas
getStringCollection returns a mutable one.
> IMO we should always return mutable collections since these methods by definition are
doing copies.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message