hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daryn Sharp (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7286) Refactor FsShell's du/dus/df
Date Tue, 17 May 2011 00:12:47 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13034441#comment-13034441
] 

Daryn Sharp commented on HADOOP-7286:
-------------------------------------

The changes were deliberate on my part.  Here's my thoughts:  FsShell tries to implement posix/unix-like
commands, but does so in its own "uniquely" inconsistent fashion which is a surprise to any
shell coder.  IMHO, if FsShell wants to be unix-like, then it's output should look unix-like,
or at a minimum be self-consistent.

I think du is the only command that is "noticably" different, particularly with regard to
the subtraction of the header.  I checked "du" on various systems and didn't find any that
printed "Found XXX items".  Going forward, I think du should be able to traverse more than
one level deep, at which point it becomes prohibitively expensive for du to sponge memory
to batch up all the output just so it can print a total on the first line.

Regarding the path display, it's been a universal change to standardize how paths are displayed
since the commands' errors and output used to be wildly inconsistent.  Typically what you
give on the cmdline is now what you get back, just like you would expect from a unix-like
system.  Although, I can tweak the du output to be absolute uris if necessary.

> Refactor FsShell's du/dus/df
> ----------------------------
>
>                 Key: HADOOP-7286
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7286
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs
>    Affects Versions: 0.23.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>         Attachments: HADOOP-7286-2.patch, HADOOP-7286-3.patch, HADOOP-7286-4.patch, HADOOP-7286.patch
>
>
> Need to refactor to conform to FsCommand subclass.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message