hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7325) hadoop command - do not accept class names starting with a hyphen
Date Fri, 27 May 2011 19:04:47 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13040390#comment-13040390
] 

Hadoop QA commented on HADOOP-7325:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12480193/hadoop-illegal-class-name-0.patch
  against trunk revision 1128385.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 system test framework.  The patch passed system test framework compile.

Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/535//testReport/
Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/535//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/535//console

This message is automatically generated.

> hadoop command - do not accept class names starting with a hyphen
> -----------------------------------------------------------------
>
>                 Key: HADOOP-7325
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7325
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: scripts
>            Reporter: Brock Noland
>            Assignee: Brock Noland
>            Priority: Minor
>         Attachments: hadoop-illegal-class-name-0.patch
>
>
> If this is committed I will look at patches for hdfs and mapred.
> When teaching a good portion of the students in every single class execute:
> {code}
> $ hadoop -fs ls /
> {code}
> The -fs is passed directly to the JVM and the JVM fails to start:
> {code}
> $ ./bin/hadoop -fs ls /
> Unrecognized option: -fs
> Could not create the Java virtual machine.
> {code}
> Which is confusing and typically requires explanation. The attached patch improves that
behavior:
> {code}
> $ ./bin/hadoop -fs ls /
> Error: No command named `-fs' was found. Perhaps you meant `hadoop fs'
> {code}
> The only risk I can see is if someone is abusing the implementation of hadoop command
doing something like so:
> {code}
> $ ./bin/hadoop -Xmx1g  org.apache.hadoop.util.RunJar
> RunJar jarFile [mainClass] args...
> {code}
> The hadoop command does not appear to advertise allowing JVM options before the classname.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message