hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tom White (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7334) test-patch should check for hard tabs
Date Fri, 27 May 2011 04:26:47 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13040050#comment-13040050
] 

Tom White commented on HADOOP-7334:
-----------------------------------

> Do you think we have a need to do something like checkstyle in the future?

We have long had a checkstyle target in ant, and plots of checkstyle violations over time
(see https://builds.apache.org/job/Hadoop-Common-trunk/), but unfortunately we haven't enforced
the rule that the number may not increase (unlike javadoc or findbugs warnings for example).

Another way of implementing this JIRA would be to enable such a rule (perhaps with a weaker
set of checkstyle rules than the current set, e.g. drop the 80-per-line rule).

> test-patch should check for hard tabs
> -------------------------------------
>
>                 Key: HADOOP-7334
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7334
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build, test
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Minor
>         Attachments: hadoop-7334.txt, hadoop-7334.txt
>
>
> Our coding guidelines say that hard tabs are disallowed in the Hadoop code, but they
sometimes sneak in (there are about 280 in the common codebase at the moment).
> We should run a simple check for this in the test-patch process so it's harder for them
to sneak in.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message