hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Lipcon (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HADOOP-7334) test-patch should check for hard tabs
Date Fri, 27 May 2011 02:01:47 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-7334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Todd Lipcon updated HADOOP-7334:
--------------------------------

    Attachment: hadoop-7334.txt

You're absolutely right about the first -c.. I was testing with a patch that had only one
tab so I didn't notice :)

Something like checkstyle probably makes sense at some point, but right now we have so many
violations that it would be a big change. Spaces vs tabs is one thing everyone agrees on and
where there's never any question of "aesthetics" :) So let's start here and maybe some day
ease in some checkstyle.

> test-patch should check for hard tabs
> -------------------------------------
>
>                 Key: HADOOP-7334
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7334
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build, test
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Minor
>         Attachments: hadoop-7334.txt, hadoop-7334.txt
>
>
> Our coding guidelines say that hard tabs are disallowed in the Hadoop code, but they
sometimes sneak in (there are about 280 in the common codebase at the moment).
> We should run a simple check for this in the test-patch process so it's harder for them
to sneak in.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message