hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Lipcon (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7334) test-patch should check for hard tabs
Date Fri, 27 May 2011 02:15:47 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13040031#comment-13040031
] 

Todd Lipcon commented on HADOOP-7334:
-------------------------------------

IMO 80 chars per line is one of those things that should be kept in general, but if the occasional
line flows over it's not a big deal. There's some times when it's much less readable to try
to keep to it.

But this is where we get into religious wars ;-) I'm a 100-per-line devotee myself!

> test-patch should check for hard tabs
> -------------------------------------
>
>                 Key: HADOOP-7334
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7334
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build, test
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Minor
>         Attachments: hadoop-7334.txt, hadoop-7334.txt
>
>
> Our coding guidelines say that hard tabs are disallowed in the Hadoop code, but they
sometimes sneak in (there are about 280 in the common codebase at the moment).
> We should run a simple check for this in the test-patch process so it's harder for them
to sneak in.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message