Return-Path: Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: (qmail 24766 invoked from network); 12 Apr 2011 22:06:43 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 12 Apr 2011 22:06:43 -0000 Received: (qmail 29935 invoked by uid 500); 12 Apr 2011 22:06:43 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 29862 invoked by uid 500); 12 Apr 2011 22:06:43 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 29854 invoked by uid 99); 12 Apr 2011 22:06:43 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Apr 2011 22:06:43 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Apr 2011 22:06:42 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id B49B59E989 for ; Tue, 12 Apr 2011 22:06:05 +0000 (UTC) Date: Tue, 12 Apr 2011 22:06:05 +0000 (UTC) From: "Daryn Sharp (JIRA)" To: common-issues@hadoop.apache.org Message-ID: <1302520095.53552.1302645965736.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <594389077.53542.1302645725966.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Updated] (HADOOP-7224) Add command factory to FsShell MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-7224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daryn Sharp updated HADOOP-7224: -------------------------------- Attachment: HADOOP-7224.patch [exec] +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 3 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 system test framework. The patch passed system test framework compile. > Add command factory to FsShell > ------------------------------ > > Key: HADOOP-7224 > URL: https://issues.apache.org/jira/browse/HADOOP-7224 > Project: Hadoop Common > Issue Type: Improvement > Affects Versions: 0.22.0 > Reporter: Daryn Sharp > Assignee: Daryn Sharp > Attachments: HADOOP-7224.patch > > > The FsShell has many chains if/then/else chains for instantiating and running commands. A dynamic mechanism is needed for registering commands such that FsShell requires no changes when adding new commands. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira