Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-issues@hadoop.apache.org
Date: Fri, 11 Mar 2011 19:37:59 +0000 (UTC)
From: "Jitendra Nath Pandey (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: 
 <1891070034.14196.1299872279422.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <645678321.2624.1299535019917.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] Commented: (HADOOP-7166) DaemonFactory should be moved from
 HDFS to common
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-7166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13005800#comment-13005800 ] 

Jitendra Nath Pandey commented on HADOOP-7166:
----------------------------------------------

ant test was run manually. 

test patch results

     [exec] -1 overall.  
     [exec] 
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] 
     [exec]     -1 tests included.  The patch doesn't appear to include any new or modified tests.
     [exec]                         Please justify why no new tests are needed for this patch.
     [exec]                         Also please list what manual steps were performed to verify this patch.
     [exec] 
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec] 
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
     [exec] 
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.
     [exec] 
     [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.
     [exec] 
     [exec]     +1 system test framework.  The patch passed system test framework compile.

No new tests added, because DaemonFactory is a new class with a single method to construct a new Daemon, and it is not used in common. It is used in HDFS and it should be sufficient to test it there.

> DaemonFactory should be moved from HDFS to common
> -------------------------------------------------
>
>                 Key: HADOOP-7166
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7166
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Jitendra Nath Pandey
>            Assignee: Jitendra Nath Pandey
>         Attachments: HADOOP-7166.1.patch, HADOOP-7166.2.patch
>
>
> DaemonFactory class is defined in hdfs util. common would be a better place for this class.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira