Return-Path: Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: (qmail 84057 invoked from network); 10 Mar 2011 22:18:21 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 10 Mar 2011 22:18:21 -0000 Received: (qmail 3221 invoked by uid 500); 10 Mar 2011 22:18:21 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 3125 invoked by uid 500); 10 Mar 2011 22:18:21 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 3116 invoked by uid 99); 10 Mar 2011 22:18:21 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 10 Mar 2011 22:18:21 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 10 Mar 2011 22:18:20 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id C3EBA3A2A3B for ; Thu, 10 Mar 2011 22:17:59 +0000 (UTC) Date: Thu, 10 Mar 2011 22:17:59 +0000 (UTC) From: "Daryn Sharp (JIRA)" To: common-issues@hadoop.apache.org Message-ID: <1837181934.11973.1299795479796.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1975706251.11966.1299795239567.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] Updated: (HADOOP-7180) Improve CommandFormat MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-7180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daryn Sharp updated HADOOP-7180: -------------------------------- Attachment: HADOOP-7180.patch Add a slew of tests, add exceptions for too many/few, allowing parsing a list. Backwards compatibility. > Improve CommandFormat > --------------------- > > Key: HADOOP-7180 > URL: https://issues.apache.org/jira/browse/HADOOP-7180 > Project: Hadoop Common > Issue Type: Improvement > Reporter: Daryn Sharp > Fix For: 0.22.0 > > Attachments: HADOOP-7180.patch > > > CommandFormat currently takes an array and offset for parsing and returns a list of arguments. It'd be much more convenient to have it process a list too. It would also be nice to differentiate between too few and too many args instead of the generic "Illegal number of arguments". Finally, CommandFormat is completely devoid of tests. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira