hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo (Nicholas), SZE (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-7180) Improve CommandFormat
Date Tue, 15 Mar 2011 23:07:29 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13007263#comment-13007263
] 

Tsz Wo (Nicholas), SZE commented on HADOOP-7180:
------------------------------------------------

- Please use junit 4 (i.e. {{org.junit.Test}} and other classes {{org.junit.*}} instead of
{{junit.framework.TestCase}})
- All public classes and methods (except tests) must have javadoc.
- How about passing {{minPar}}/{{maxPar}} and {{psize}} to {{NotEnoughArgumentsException}}/{{TooManyArgumentsException}}
and then shows the numbers in the error messages?
- Minor: how about passing {{pos}} to {{parse(List<String> args)}}, so that we could
just return {{parse(Arrays.asList(args), pos)}} in {{parse(String[] args, int pos)}}?

> Improve CommandFormat
> ---------------------
>
>                 Key: HADOOP-7180
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7180
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>             Fix For: 0.23.0
>
>         Attachments: HADOOP-7180.patch
>
>
> CommandFormat currently takes an array and offset for parsing and returns a list of arguments.
 It'd be much more convenient to have it process a list too.  It would also be nice to differentiate
between too few and too many args instead of the generic "Illegal number of arguments".  Finally,
CommandFormat is completely devoid of tests.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message