hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo (Nicholas), SZE (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7202) Improve Command base class
Date Mon, 28 Mar 2011 17:15:06 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13012145#comment-13012145

Tsz Wo (Nicholas), SZE commented on HADOOP-7202:

Hi Daryn,

- Could you add the annotations to the existing classes?

- Since they are private unstable interfaces, you may simply remove the methods.  Otherwise,
please explain in the javadoc that why these methods are deprecated and what are the alternatives.
> The javac warnings are due to FsCommand.java stubbing out unnecessary abstract methods
which happen to be deprecated. ...

- If {{FsCommand}} is not useful now, how about adding it later when it becomes useful?
+// this class may not look useful now, but it's a placeholder for future
+// functionality to act as a registry for fs commands.  currently it's being
+// used to implement unnecessary abstract methods in the base class
+abstract public class FsCommand extends Command {

> Improve Command base class
> --------------------------
>                 Key: HADOOP-7202
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7202
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 0.22.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>             Fix For: 0.23.0
>         Attachments: HADOOP-7202-2.patch, HADOOP-7202-3.patch, HADOOP-7202.patch
> Need to extend the Command base class to allow all command to easily subclass from a
code set of code that correctly handles globs and exit codes.

This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message