hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-7131) set() and toString Methods of the org.apache.hadoop.io.Text class does not include the root exception, in the wrapping RuntimeException.
Date Fri, 04 Mar 2011 17:43:37 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13002738#comment-13002738
] 

Hadoop QA commented on HADOOP-7131:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12472667/HADOOP-7131.patch
  against trunk revision 1077811.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

    +1 system test framework.  The patch passed system test framework compile.

Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/301//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/301//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/301//console

This message is automatically generated.

> set() and toString Methods of the org.apache.hadoop.io.Text class does not include the
root exception, in the wrapping RuntimeException.
> ----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7131
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7131
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: io
>    Affects Versions: 0.20.1, 0.20.2
>            Reporter: Uma Maheswara Rao G
>            Priority: Minor
>         Attachments: HADOOP-7131.patch
>
>
>  In below code snippets, we can include e, instead of e.toString(), so that caller can
get complete trace.
> 1) 
>    /** Set to contain the contents of a string.
>    */
>   public void set(String string) {
>     try {
>       ByteBuffer bb = encode(string, true);
>       bytes = bb.array();
>       length = bb.limit();
>     }catch(CharacterCodingException e) {
>       throw new RuntimeException("Should not have happened ",e.toString());
>     }
>   } 
> 2)
>    public String toString() {
>     try {
>       return decode(bytes, 0, length);
>     } catch (CharacterCodingException e) {
>       throw new RuntimeException("Should not have happened ",e.toString());
>     }
>   }

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message