hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Lipcon (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-7139) Allow appending to existing SequenceFile and MapFile and allow configuration of blocksize
Date Thu, 24 Feb 2011 00:53:39 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12998634#comment-12998634
] 

Todd Lipcon commented on HADOOP-7139:
-------------------------------------

- looks like the patch introduces some incorrect whitespace - our coding style is to use two
spaces for indentation, and no "hard tabs"
- appending to a seqfile should probably check that the version of the seqfile to be appended
is the same as the current file format version - I see you added a getVersion() function but
it's not used.
- the Release Note and JIRA description indicates support for appending to MapFile, but that
isn't available in the API.
- It seems the change to be able to specify the compression block size is a separate logical
change from the ability to append. We should probably break this into two JIRAs since it's
two different features.

> Allow appending to existing SequenceFile and MapFile and allow configuration of blocksize
> -----------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7139
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7139
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: io
>    Affects Versions: 0.20.1
>            Reporter: Stephen Rose
>            Priority: Minor
>             Fix For: 0.23.0
>
>         Attachments: HADOOP-7139.patch, HADOOP-7139.patch, HADOOP-7139.patch, HADOOP-7139.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>


-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message