hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-6902) RPC server's SASL_PROPS shouldn't be re-initialized every time an RPC client is created
Date Sat, 19 Feb 2011 21:46:38 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-6902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12996884#comment-12996884
] 

Hadoop QA commented on HADOOP-6902:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12453821/c6902-04.patch
  against trunk revision 1071364.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    -1 patch.  The patch command could not apply the patch.

Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/264//console

This message is automatically generated.

> RPC server's SASL_PROPS shouldn't be re-initialized every time an RPC client is created
> ---------------------------------------------------------------------------------------
>
>                 Key: HADOOP-6902
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6902
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: ipc, security
>            Reporter: Kan Zhang
>            Assignee: Kan Zhang
>         Attachments: c6902-03.patch, c6902-04.patch
>
>
> SaslRpcServer.SASL_PROPS is a SASL server property and should stay constant after initialization.
In the initial implementation, we assumed all SASL clients will use the same constant value.
If different clients might use different values depending on the conf in the getProxy() call
(as current code implies), each client should have its own copy. In any case, a client shouldn't
re-initialize server's copy.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message