Return-Path: Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: (qmail 18894 invoked from network); 25 Jan 2011 23:04:07 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 25 Jan 2011 23:04:07 -0000 Received: (qmail 5292 invoked by uid 500); 25 Jan 2011 23:04:07 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 5215 invoked by uid 500); 25 Jan 2011 23:04:06 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 5207 invoked by uid 99); 25 Jan 2011 23:04:06 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 25 Jan 2011 23:04:06 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 25 Jan 2011 23:04:06 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id p0PN3jmx017154 for ; Tue, 25 Jan 2011 23:03:46 GMT Message-ID: <4161083.203041295996625806.JavaMail.jira@thor> Date: Tue, 25 Jan 2011 18:03:45 -0500 (EST) From: "Hadoop QA (JIRA)" To: common-issues@hadoop.apache.org Subject: [jira] Commented: (HADOOP-7118) NPE in Configuration.writeXml In-Reply-To: <25553485.202661295995906384.JavaMail.jira@thor> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-7118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12986747#action_12986747 ] Hadoop QA commented on HADOOP-7118: ----------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12469351/hadoop-7118.txt against trunk revision 1063090. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/198//console This message is automatically generated. > NPE in Configuration.writeXml > ----------------------------- > > Key: HADOOP-7118 > URL: https://issues.apache.org/jira/browse/HADOOP-7118 > Project: Hadoop Common > Issue Type: Bug > Affects Versions: 0.22.0 > Reporter: Todd Lipcon > Assignee: Todd Lipcon > Priority: Blocker > Fix For: 0.22.0 > > Attachments: hadoop-7118.txt > > > In HADOOP-7082 I stupidly introduced a regression whereby Configuration.writeXml will throw an NPE if it is called before any .get() call is made, since the properties member is not initialized. This is causing a failure in TestCapacitySchedulerWithJobTracker on my box, but doesn't appear to trigger any failures in the non-contrib tests since .get() is usually called first. > This JIRA is to fix the bug and add a unit test for writeXml in common (apparently it never had a unit test) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.