hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-7118) NPE in Configuration.writeXml
Date Tue, 25 Jan 2011 23:33:43 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12986768#action_12986768
] 

Hadoop QA commented on HADOOP-7118:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12469356/hadoop-7118.txt
  against trunk revision 1063090.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

    +1 system test framework.  The patch passed system test framework compile.

Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/199//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/199//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/199//console

This message is automatically generated.

> NPE in Configuration.writeXml
> -----------------------------
>
>                 Key: HADOOP-7118
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7118
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Blocker
>             Fix For: 0.22.0
>
>         Attachments: hadoop-7118.txt, hadoop-7118.txt
>
>
> In HADOOP-7082 I stupidly introduced a regression whereby Configuration.writeXml will
throw an NPE if it is called before any .get() call is made, since the properties member is
not initialized. This is causing a failure in TestCapacitySchedulerWithJobTracker on my box,
but doesn't appear to trigger any failures in the non-contrib tests since .get() is usually
called first.
> This JIRA is to fix the bug and add a unit test for writeXml in common (apparently it
never had a unit test)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message