Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-issues@hadoop.apache.org
Message-ID: <7447264.30731291868761458.JavaMail.jira@thor>
Date: Wed, 8 Dec 2010 23:26:01 -0500 (EST)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Subject: [jira] Commented: (HADOOP-7060) A more elegant
 FileSystem#listCorruptFileBlocks API
In-Reply-To: <15772860.26651291850401483.JavaMail.jira@thor>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-7060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12969624#action_12969624 ] 

Hadoop QA commented on HADOOP-7060:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12465880/HADOOP-7060.patch
  against trunk revision 1043117.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

    +1 system test framework.  The patch passed system test framework compile.

Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/136//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/136//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/136//console

This message is automatically generated.

> A more elegant FileSystem#listCorruptFileBlocks API
> ---------------------------------------------------
>
>                 Key: HADOOP-7060
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7060
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Hairong Kuang
>            Assignee: Patrick Kling
>         Attachments: HADOOP-7060.patch
>
>
> I'd like to change the newly added listCorruptFileBlocks signature to be:
> {code}
> /**
> * Get all files with corrupt blocks under the given path
> */
> RemoteIterator<Path> listCorruptFileBlocks(Path src) throws IOException;
> {code}
> This new API does not expose "cookie" to user although underlying implementation may still need to invoke multiple RPCs to get the whole list.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.